Skip to content

Init extension #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
May 15, 2023
Merged

Init extension #1

merged 40 commits into from
May 15, 2023

Conversation

paulacamargo25
Copy link
Contributor

@paulacamargo25 paulacamargo25 commented Apr 4, 2023

Set python debugger extension

Closed: #2

},
"envFile": {
"default": "${workspaceFolder}/.env",
"description": "Absolute path to a file containing environment variable definitions.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what the behavior of "envFile" is if "env" is present - might want to mention that they're merged with "env" taking precedence (I think that's what vscode-python does?).


// This situation occurs when user connects to old containers or server where
// the debugger they had installed was ptvsd. We should show a prompt to ask them to update.
class OutdatedDebuggerPrompt implements DebugAdapterTracker {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to provide this but we can re-visit this later

@karthiknadig
Copy link
Member

There are lot more items to clean and remove before we can build this properly. Also, the nox scrip will package python 3.7 wheels, we need to make it build with 3.9 and 3.10. That will need a different script.

We can merge this after the next set of changes. But we should not enable build.

karthiknadig
karthiknadig previously approved these changes May 9, 2023
@paulacamargo25 paulacamargo25 merged commit fc5256e into main May 15, 2023
@paulacamargo25 paulacamargo25 deleted the Init-extension branch May 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to node 16
3 participants